Gift Card Mutation Added #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for creating the PR. But the PR is incomplete. The updateGiftCardCodesMutation you created has the appliedGiftCards property, but the Cart model does not seem to have been updated to reflect the changes. You can not access the applied gift card property in the cart. If it was intended, then please remove the appliedGiftCards from the mutation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #98 has been solved. Which was opened by me previous week.
I have added mutation to update Gift Card codes on the Cart.
It's just like Discount Code Update mutation which accepts the List of codes to apply or remove/update.