这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ilsubyeega
Copy link
Owner

@ilsubyeega ilsubyeega commented Mar 20, 2024

Todos:

Another issue mentioned on README.md can be an afterthought, and the above checklist is the minimum svelte 5 support should work.

@dummdidumm
Copy link

👋 Svelte maintainer here. Can you elaborate on the "svelte5 rendering slow specifically on storybook due to deep_read" part? Where can I see that in this PR?

@ilsubyeega
Copy link
Owner Author

ilsubyeega commented May 10, 2024

👋 Svelte maintainer here. Can you elaborate on the "svelte5 rendering slow specifically on storybook due to deep_read" part? Where can I see that in this PR?

@dummdidumm

Oh hello, didn't expect to comment. I tried to change the props of a svelte component in storybook and it was getting laggy and when I profiled it, deep_read was getting most of the blocking.

If I remember correctly, Storybook's svelte 5 implementation was unfinished at the time. It may be changed So I'll have to recheck again.

Just in case, here's the screenshot and profiler url.
image
https://share.firefox.dev/3UQ5O1H

Edit: Issue still persists on version bump, i hope to guess the lack of svelte5 dedicated support from storybook's svelte renderer.

https://share.firefox.dev/4aeah2K

Screencast.from.2024-05-10.22-35-08.webm

@ilsubyeega ilsubyeega linked an issue May 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use svelte v5

3 participants