-
Notifications
You must be signed in to change notification settings - Fork 1
[DRAFT] Svelte5 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Svelte maintainer here. Can you elaborate on the "svelte5 rendering slow specifically on storybook due to deep_read" part? Where can I see that in this PR? |
Oh hello, didn't expect to comment. I tried to change the props of a svelte component in storybook and it was getting laggy and when I profiled it, deep_read was getting most of the blocking. If I remember correctly, Storybook's svelte 5 implementation was unfinished at the time. It may be changed So I'll have to recheck again. Just in case, here's the screenshot and profiler url. Edit: Issue still persists on version bump, i hope to guess the lack of svelte5 dedicated support from storybook's svelte renderer. https://share.firefox.dev/4aeah2K Screencast.from.2024-05-10.22-35-08.webm |
Todos:
Performance issue with runes / non-runes interop and
deep_readon large datasets sveltejs/svelte#10637Another issue mentioned on
README.mdcan be an afterthought, and the above checklist is the minimum svelte 5 support should work.