Add deployment section to README #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Great work, again! |
|
Thanks Tony definitely a great addition to the readme. As THAT user in your
reason for change it is much appreciated. Perfect place for a quick demo or
proof of concept.
…On Tue, Nov 28, 2023, 3:57 PM Tony Dang, ***@***.***> wrote:
Summary
Add a Deployment section to the README with a guide on how to deploy a
LiveSvelte app to Fly.io.
Reason for change
As a user, I would like to know how to deploy my apps. Deployment of a
LiveSvelte app is more involved than deploying a regular Phoenix app since
it requires nodejs to be available in production. Having a guide to help
users with deployment may help with adoption of LiveSvelte.
------------------------------
You can view, comment on, or merge this pull request online at:
#99
Commit Summary
- fb325b4
<fb325b4>
add deployment guide to README
- 389cfe7
<389cfe7>
add link to deployment section
File Changes
(1 file <https://github.com/woutdp/live_svelte/pull/99/files>)
- *M* README.md
<https://github.com/woutdp/live_svelte/pull/99/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(87)
Patch Links:
- https://github.com/woutdp/live_svelte/pull/99.patch
- https://github.com/woutdp/live_svelte/pull/99.diff
—
Reply to this email directly, view it on GitHub
<#99>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE55VEKTK5X47AYG7JBKS5DYGZF4RAVCNFSM6AAAAAA76MKFQGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTKMZQGIYTEMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a Deployment section to the README with a guide on how to deploy a LiveSvelte app to Fly.io.
Reason for change
As a user, I would like to know how to deploy my apps. Deployment of a LiveSvelte app is more involved than deploying a regular Phoenix app since it requires
nodejsto be available in production. Having a guide to help users with deployment may help with adoption of LiveSvelte.