这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix some small issues #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

Fix some small issues #60

merged 1 commit into from
Jul 30, 2023

Conversation

@vonagam
Copy link
Contributor

@vonagam vonagam commented Jul 30, 2023

  • json and liveJsonData variables in getLiveJsonProps were missing declaration specifier. The code was not working in strict mode.

  • Svelte was complaining about compilerOptions.css being boolean in the client config, set it to corresponding proper string value - injected.

  • hydrate should be true only if there was ssr involved, was getting errors about it, added data-ssr attribute to indicate server rendering.

  • other stuff is just cosmetics, making things consistent.

@vonagam vonagam force-pushed the fix-small-issues branch from 727466e to f443aab Compare July 30, 2023 16:16
@vonagam
Copy link
Contributor Author

vonagam commented Jul 30, 2023

  • In LiveSvelte.Components.get_svelte_components do not do search subdirectories since currently only top level svelte components are actually supported (in name_to_function there is no expectation for name to include a directory, only a basename is used, meaning that component name prop will be wrong as it should include a full path), also removes need to filter out _build folder. Can undo this change and add support for nested ones, it will expect that all components should have different basenames.

@woutdp
Copy link
Owner

woutdp commented Jul 30, 2023 •
edited
Loading

Thanks for the changes/fixes!

The get_svelte_components function has an error in it though, fn doesn't end with end. The other changes look good :)

@vonagam vonagam force-pushed the fix-small-issues branch from f443aab to 075188e Compare July 30, 2023 16:38
@vonagam
Copy link
Contributor Author

vonagam commented Jul 30, 2023

Added end.

@woutdp woutdp merged commit ceb4fee into woutdp:master Jul 30, 2023
@vonagam vonagam deleted the fix-small-issues branch July 30, 2023 16:47
@woutdp
Copy link
Owner

woutdp commented Jul 30, 2023

Available in version 0.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vonagam @woutdp