add ability to set timezone on events in iOS. necessary for recurrenc… #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e expansion to work correctly across daylight savings time transitions
Collaborator
|
Hi @mcarlson, could you add some documentation? And maybe adjust index.d.ts for the signature? Thank you! |
Contributor
Author
|
I added some documentation. Let me know what else you need, thank you! |
Owner
|
Thanks @mcarlson! |
MoOx
reviewed
Jan 8, 2021
Collaborator
MoOx
left a comment
There was a problem hiding this comment.
Just a small change and a minor issue in TS definition but I will fix that on master :)
Thanks for this!
| You need to be sure that the event you saved is matching what your device will keep in sync. | ||
|
|
||
| For iOS, you might have not all event synced. You might need to update this iOS settings in _Settings_ > _Calendar_ > _Sync_ > **All Events**. If that's not enough, it might be worth checking [iOS iCloud sync documentation](https://support.apple.com/en-us/HT203521). | ||
| For iOS, you might have not all event synced. You might need to update this iOS settings in _Settings_ > _Calendar_ > _Sync_ > **All Events**. If that's not enough, it might be worth checking [iOS iCloud sync documentation](https://support.apple.com/en-us/HT203521). |
Collaborator
There was a problem hiding this comment.
Suggested change
| For iOS, you might have not all event synced. You might need to update this iOS settings in _Settings_ > _Calendar_ > _Sync_ > **All Events**. If that's not enough, it might be worth checking [iOS iCloud sync documentation](https://support.apple.com/en-us/HT203521). | |
| For iOS, you might have not all event synced. You might need to update this iOS settings in _Settings_ > _Calendar_ > _Sync_ > **All Events**. If that's not enough, it might be worth checking [iOS iCloud sync documentation](https://support.apple.com/en-us/HT203521). |
| notes?: string; | ||
| /** ANDROID ONLY - The description associated with the calendar event. */ | ||
| description?: string; | ||
| /** iOS ONLY - The time zone associated with the event |
Collaborator
There was a problem hiding this comment.
Suggested change
| /** iOS ONLY - The time zone associated with the event | |
| /** iOS ONLY - The time zone associated with the event. */ |
Collaborator
|
Available in 2.2.0, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e expansion to work correctly across daylight savings time transitions