Change android calendar query to catch events that intersect date ran… #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge but aren't entirely a subset
Collaborator
|
Seems to be promising! |
Owner
|
Great catch! I'm surprised this has not been more of an issue. 👍 |
Collaborator
|
Available in 2.2.0, thanks again! |
Contributor
Author
|
Awesome! thanks for the heads up on release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a difference between how iOS and Android fetchEvents. Given start and end dates, iOS will gets the intersection of events for those dates whereas Android is getting a subset.
For example:
Start and end dates are 2020-11-25T08:00:00.000Z and 2020-11-25T09:00:00.000Z
The event we are expecting goes from 2020-11-25T08:30:00.000Z and 2020-11-25T09:30:00.000Z
The iOS version will return this event but the Android version won't.
So change the date filter to look for events that start before our end date and end after our start date