Added key to skip setting timezone on android #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Any chance this could be merged? I really need this fix |
Contributor
Author
|
Is this repo live? |
|
I am facing this issue too, I didn't check all the library but why doesn't the library just change the format to |
Contributor
Author
|
I forked the repo with this change. You can use it like "react-native-calendar-events":"eleddie/react-native-calendar-events#master" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the format
YYYY-MM-DDTHH:mm:ss.SSSZit works fine on ios but on android it gives the following error:Unparseable date: "2019-08-22T15:00:00.000-05:00"To fix this, people use the format
YYYY-MM-DDTHH:mm:ss.SSS[Z]which gives2019-08-22T15:00:00.000Zand works fine.The problem is that since I am in a different timezone (GTM-5) that part gets lost when using the latter time format and the event is added 5 hours earlier than the actual time passed.
This PR adds the ability to skip setting the time format on the native side by setting
skipAndroidTimezone: truein the details passed tosaveEvent.Ideally the library should accept the format
YYYY-MM-DDTHH:mm:ss.SSSZso the timezone part doesn't get lost.This probably fixes #229 and #232 which are closed but I didn't find my answer there