Updated docs with correct type for string dates #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is confusing to have type Date in the documentation, when, in reality, a String is expected.
Contributor
|
A little context relating to this issue - We are having to update our code now that calls RNCalendarEvents API's because we were previously passing Date objects to the API's, and it used to work fine. We now have upgraded to RN 59, and now we are getting errors in iOS. I think something must have changed in the RN bridge related code that now breaks if you pass JS Date objects across the bridge to be converted to NSDate objects. Updating our code to pass strings instead works correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is confusing to have type Date in the documentation, when, in reality, a String is expected.