android: use PermissionListener to avoid Android manual steps #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@wmcmahan gentle ping :-) |
Owner
|
Thanks @saghul! |
Contributor
|
@saghul do you have an idea of how the last part of the wiki should be changed / clarified? It could form the basis of a quick note on "how to upgrade" for people using the original style before the API change... |
Collaborator
Author
|
@mikehardy The part with calling the onPermissionResult wouldn't be needed. I see that this got reverted however 😞 |
Contributor
|
@saghul it was just because of a semver thing, nothing bad about the patch I don't think, specifically - #248 - which makes it seem like there will be a 2.x with it back in? But maybe only if you re-PR with the changes (maintaining isn't easy so the easier you make it the quicker things get done). Cheers! |
Collaborator
Author
|
Done in #252 cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When / if this lands, the last part of the wiki needs to be removed / clarified, since it'll be no longer needed: https://github.com/wmcmahan/react-native-calendar-events/wiki/Android-setup