这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@aarkalyk
Copy link
Contributor

Hey 👋🏽

Small PR to add Typescript definitions ✨

@wmcmahan
Copy link
Owner

Cool! Thanks @aarkalyk

@wmcmahan wmcmahan merged commit 0745c56 into wmcmahan:master Mar 31, 2019
@aarkalyk
Copy link
Contributor Author

aarkalyk commented Apr 2, 2019

@wmcmahan Thanks for merging! Can you please publish a new version of the package?

@wmcmahan
Copy link
Owner

wmcmahan commented Apr 2, 2019

@aarkalyk There are other changes needed. I will publish when everything is set.

@bramski
Copy link

bramski commented Oct 14, 2020

Did this ever get published?

@MoOx
Copy link
Collaborator

MoOx commented Oct 14, 2020

Did you ever tried to upgrade or looks at the package en npm?

@bramski
Copy link

bramski commented Oct 15, 2020

The file appears to be there, src/index.d.ts but it's ineffective at least in my IDE (Webstorm). So something seems wrong with how it's being referenced I would guess. This is version 2.1.0

@wmcmahan
Copy link
Owner

@bramski Sorry, looks like with some directory changes in V2 the TS declarations moved from the root of the project and fell out of reference. This should correct it: #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants