Scope non-scoped (global) registries to a single document #11472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the global custom element registry not escape its document for now. We throw an exception to give us some wiggle room in the future. DOM issue and PR: whatwg/dom#1390 & whatwg/dom#1392. Tests: TODO.
5 tasks
@ja-y-son to review for Chromium |
|
Do we want to apply similar constraint while attaching shadow using |
|
Yes we do. See the corresponding DOM PR. |
|
The changes lgtm! |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2025
Align with the changes in whatwg/dom#1392 and whatwg/html#11472, add many more tests, and correct several tests.
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Jul 23, 2025
This preserves existing behavior. We throw exceptions in certain corner cases to give us some wiggle room in the future. Corresponding HTML PR: whatwg/html#11472. Tests: web-platform-tests/wpt#53791. Fixes #1390.
Post-merge, but this LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the global custom element registry not escape its document for now. We throw an exception to give us some wiggle room in the future.
DOM issue and PR: whatwg/dom#1390 & whatwg/dom#1392.
Tests: web-platform-tests/wpt#53791.
(See WHATWG Working Mode: Changes for more details.)
/custom-elements.html ( diff )