这是indexloc提供的服务,不要输入任何密码
Skip to content

[WebDriver BiDi] report download complete / canceled #11289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented May 7, 2025

Add a hook for reporting file download ended (complete or canceled) and provide the downloaded file path there. Required for WebDriver BiDi browsingContext.downloadEnd event.

Refactoring

In order to provide the proper events' order, the "WebDriver BiDi download started" hook was moved into "handle as a download".
TODO: check if the <var>navigable</var> and <var>navigationId</var> really can be null there.

Specification

As long as the download processing is non-normative, the generic description was used:

  • "If the file downloading was canceled by user or by the user agent"
  • "If the file downloading faced any problems"
  • "When the file downloading successfully completed"
  • At least two implementers are interested (and none opposed):
  • Chromium
  • Mozilla

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )
/infrastructure.html ( diff )
/links.html ( diff )

@sadym-chromium sadym-chromium changed the title [WebDriver BiDi] report download complete / failed / canceled [DRAFT][WebDriver BiDi] report download complete / failed / canceled May 14, 2025
@sadym-chromium sadym-chromium changed the title [DRAFT][WebDriver BiDi] report download complete / failed / canceled [DRAFT][WebDriver BiDi] report download complete / canceled May 19, 2025
sadym-chromium added a commit to w3c/webdriver-bidi that referenced this pull request Jun 3, 2025
Addressing [Access downloaded file content · Issue #894 · w3c/webdriver-bidi](#894).

The "WebDriver BiDi download end" hook is to be engaged in HTML spec [[WebDriver BiDi] report download complete / failed / canceled by sadym-chromium · Pull Request #11289 · whatwg/html](whatwg/html#11289)
@sadym-chromium sadym-chromium force-pushed the sadym/download-status branch from 7542b32 to fa63b44 Compare June 25, 2025 08:43
@sadym-chromium sadym-chromium changed the title [DRAFT][WebDriver BiDi] report download complete / canceled [WebDriver BiDi] report download complete / canceled Jun 25, 2025
Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address TODO's in the description

</li>

<li>
<p>When the file downloading successfully completed:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if these steps "if the file downloading was canceled by user or by the user agent, or if the file downloading faced any problems" and "When the file downloading successfully completed" are specific enough and also they define steps that do not happen in the order of the algorithm but I will defer to the HTML spec reviewers on this.

@sadym-chromium
Copy link
Contributor Author

Closing in favor of #11474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants