-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Remove UA styles for h1 in article, aside, nav, section #11102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as abuse.
This comment was marked as abuse.
@kytans, I've hidden your comment as abuse, and encourage you to review https://whatwg.org/code-of-conduct before engaging further with the WHATWG community. Any further violations will result in at least a temporary ban. |
I think we can land this, see #7867 (comment) |
So Chrome will only follow once it's been 100% in Firefox stable for some time and apart from the warning hasn't experimented with this yet? If so I'd like to defer merging to @domenic. We might need a better way to decide these things. The main thing I'm concerned about is wasting cycles of people on the outside who assume it's happening based on a change to the HTML standard when we're in fact not that certain. |
That's much appreciated! |
That's roughly right, yes. We've had the deprecation warnings going for several milestones and haven't heard any issues. But I'd like to wait until this is shipped at 100% for at least a milestone in Firefox before we start the process in Chromium. Having said that, it looks pretty likely to go ahead, at least to me. |
We do have a few of these sorts of things recently, where everyone's on board but is unsure on the compat implications. (whatwg/webidl#1465 is another.) My tendency is to be more aggressive about merging, but I'm hearing hesitation from others... so I don't really know where that leaves us. |
I'm OK with waiting here until another browser has decided to ship. But yeah, it seems we should discuss the meta issue. |
Maybe something along these lines:
|
+1 to this approach. This (#2) is also roughly what we did for mutation events. |
This attempts to capture the best practice discussed in whatwg/html#11102 (comment).
For any following along, I've posted whatwg/sg#253 to attempt to encapsulate the above guidance into the working mode. |
Per discussion in #7867 (comment), Firefox has shipped this to stable for 2 releases at 100%. That meets the bar we've discussed above, so I think this is ready to merge. I'll plan on doing that by Monday Japan time unless more discussion happens in the meantime. |
@domenic ping to get this merged? :) |
This adds the flag to disable the special rules, and disables it by default. The flag is there as a kill switch in case of problems. I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/owM01CWwoes/m/uktPI2RDCAAJ See also: whatwg/html#7867 (comment) whatwg/html#11102 Fixed: 394111284 Change-Id: Ib25180cbc28463025f8427eb70ac35a3f0ecb012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6725454 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1490958}
Fixes #7867
(See WHATWG Working Mode: Changes for more details.)
/rendering.html ( diff )