这是indexloc提供的服务,不要输入任何密码
Skip to content

Remove UA styles for h1 in article, aside, nav, section #11102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Mar 5, 2025

@annevk annevk added needs tests Moving the issue forward requires someone to write tests needs compat analysis labels Mar 5, 2025
@mfreed7

This comment was marked as resolved.

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Mar 27, 2025
@zcorpan zcorpan removed the needs tests Moving the issue forward requires someone to write tests label Mar 31, 2025
@kytans

This comment was marked as abuse.

@domenic
Copy link
Member

domenic commented Apr 11, 2025

@kytans, I've hidden your comment as abuse, and encourage you to review https://whatwg.org/code-of-conduct before engaging further with the WHATWG community. Any further violations will result in at least a temporary ban.

@zcorpan
Copy link
Member Author

zcorpan commented May 20, 2025

I think we can land this, see #7867 (comment)

chrisdavidmills pushed a commit to mdn/content that referenced this pull request May 20, 2025
@annevk annevk added the removal/deprecation Removing or deprecating a feature label May 20, 2025
@annevk
Copy link
Member

annevk commented May 20, 2025

So Chrome will only follow once it's been 100% in Firefox stable for some time and apart from the warning hasn't experimented with this yet? If so I'd like to defer merging to @domenic. We might need a better way to decide these things. The main thing I'm concerned about is wasting cycles of people on the outside who assume it's happening based on a change to the HTML standard when we're in fact not that certain.

@AtkinsSJ
Copy link
Contributor

The main thing I'm concerned about is wasting cycles of people on the outside who assume it's happening based on a change to the HTML standard when we're in fact not that certain.

That's much appreciated!

@mfreed7
Copy link
Contributor

mfreed7 commented May 20, 2025

So Chrome will only follow once it's been 100% in Firefox stable for some time and apart from the warning hasn't experimented with this yet?

That's roughly right, yes. We've had the deprecation warnings going for several milestones and haven't heard any issues. But I'd like to wait until this is shipped at 100% for at least a milestone in Firefox before we start the process in Chromium. Having said that, it looks pretty likely to go ahead, at least to me.

@domenic
Copy link
Member

domenic commented May 21, 2025

We do have a few of these sorts of things recently, where everyone's on board but is unsure on the compat implications. (whatwg/webidl#1465 is another.) My tendency is to be more aggressive about merging, but I'm hearing hesitation from others... so I don't really know where that leaves us.

@zcorpan
Copy link
Member Author

zcorpan commented May 21, 2025

I'm OK with waiting here until another browser has decided to ship. But yeah, it seems we should discuss the meta issue.

@annevk
Copy link
Member

annevk commented May 21, 2025

Maybe something along these lines:

  1. If multiple browsers are landing patches and little fallout is expected, as was the case with escaping < and > in attribute values near the end, let's proceed and align the standard assuming success.
  2. If other browsers are wary but supportive, let's wait until one browser has actually shipped the new behavior before aligning the standard. (Which means once Firefox 140 ships we'd land this PR and assume eventual success.)

@mfreed7
Copy link
Contributor

mfreed7 commented May 22, 2025

Maybe something along these lines:

  1. If multiple browsers are landing patches and little fallout is expected, as was the case with escaping < and > in attribute values near the end, let's proceed and align the standard assuming success.
  2. If other browsers are wary but supportive, let's wait until one browser has actually shipped the new behavior before aligning the standard. (Which means once Firefox 140 ships we'd land this PR and assume eventual success.)

+1 to this approach. This (#2) is also roughly what we did for mutation events.

domenic added a commit to whatwg/sg that referenced this pull request May 23, 2025
This attempts to capture the best practice discussed in whatwg/html#11102 (comment).
@domenic
Copy link
Member

domenic commented May 23, 2025

For any following along, I've posted whatwg/sg#253 to attempt to encapsulate the above guidance into the working mode.

@domenic
Copy link
Member

domenic commented Jul 10, 2025

Per discussion in #7867 (comment), Firefox has shipped this to stable for 2 releases at 100%. That meets the bar we've discussed above, so I think this is ready to merge.

I'll plan on doing that by Monday Japan time unless more discussion happens in the meantime.

@emilio
Copy link
Contributor

emilio commented Jul 18, 2025

@domenic ping to get this merged? :)

@domenic domenic merged commit 1af7430 into main Jul 19, 2025
2 checks passed
@domenic domenic deleted the zcorpan/h1-styles branch July 19, 2025 02:24
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 23, 2025
This adds the flag to disable the special rules, and disables it
by default. The flag is there as a kill switch in case of problems.

I2S:
https://groups.google.com/a/chromium.org/g/blink-dev/c/owM01CWwoes/m/uktPI2RDCAAJ

See also:
whatwg/html#7867 (comment)
whatwg/html#11102

Fixed: 394111284
Change-Id: Ib25180cbc28463025f8427eb70ac35a3f0ecb012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6725454
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1490958}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal/deprecation Removing or deprecating a feature topic: rendering
Development

Successfully merging this pull request may close these issues.

Remove UA style for h1-h6 in section (et. al.) and hgroup
7 participants