-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Define customizable <select>
#10548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define customizable <select>
#10548
Conversation
8be5f47
to
0bee650
Compare
4691e13
to
bef9083
Compare
34be830
to
fed19dc
Compare
FYI: I am likely going to remove the author-provided datalist and fallback UA button in this PR soon based on recent discussions, which will likely reduce the number of changes and complexity. |
6dab95d
to
57e00bf
Compare
50bf192
to
12edc88
Compare
Should this PR be closed, to avoid confusion? I believe it's been completely superseded by the list at the top of #9799, right? |
Yes I'm not keeping this up to date anymore since I decided to split out the PRs and have slight redundancies |
5e7ad83
to
82a3769
Compare
I did a review here to try to finish this off. I pushed several editorial commits. @josepharhar, please review them. The conformance requirements look reasonable to me. However, one issue makes me think this is not ready. There are multiple definitions for option HTML element insertion/removing steps, one in the select element section, and one in the option element section. I cannot tell if they are both supposed to run, or if one has become obsolete, or what. Please update this by merging them, or deleting the obsolete one. Also, please moving the HTML element insertion/removing/moving steps, for both option and optgroup, into the sections for those elements, instead of keeping them in the select element's section. That can help prevent this sort of problem in the future. |
An additional non-blocking note (a followup PR would be fine) is that it would be good to add more examples to the spec that use the new, more complicated forms of select. |
Thanks Domenic! I fixed the duplicate insertion/removal steps. I also started a PR for examples: #11465 |
Great, thank you! Can you also move the optgroup steps to the optgroup element section, instead of having them in the select element section? |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will merge this now!
This defines several concepts related to customizable
<select>
:<select>
<select>
and related elements.<select>
<selectedcontent>
HTML element<select>
with base appearanceCloses #9799
Closes #10557
Closes #10310
Closes #10586
Closes #10317
Closes #10629
Closes #10633
Closes #10520
Closes #10670
Closes #10520
Closes #10762
<select>
parser WebKit/standards-positions#414<select>
parser mozilla/standards-positions#1086/dom.html ( diff )
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/grouping-content.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/interactive-elements.html ( diff )
/parsing.html ( diff )
/references.html ( diff )
/rendering.html ( diff )
/scripting.html ( diff )
/text-level-semantics.html ( diff )