[shared storage] Add Web Locks to the worklet #48708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explainer: WICG/shared-storage#199 Key points: - `SharedStorageWorkletNavigator` is a new interface that only supports `locks`. Implementation-wise, we inherit NavigatorBase so it's compatible with the LockManager implementation. Some methods are obviously unreachable (e.g. GetAcceptLanguages()). - Add the member `LockManager<OriginLockGroupId> lock_manager_;` to SharedStorageWorkletHostManager: The locks have a shared storage specific scope (separate from the Window/Worker locks), and are further partitioned by shared storage origin. Bug: 373899210 Change-Id: I9908962949088356c2a61c1556183ccd5772985f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937903 Reviewed-by: Ayu Ishii <ayui@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1370865}
685fa3f to
c55ee44
Compare
wpt-pr-bot
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explainer: WICG/shared-storage#199
Key points:
SharedStorageWorkletNavigatoris a new interface that onlysupports
locks. Implementation-wise, we inherit NavigatorBaseso it's compatible with the LockManager implementation. Some
methods are obviously unreachable (e.g. GetAcceptLanguages()).
LockManager\<OriginLockGroupId> lock_manager_;toSharedStorageWorkletHostManager: The locks have a shared storage
specific scope (separate from the Window/Worker locks), and are
further partitioned by shared storage origin.
Bug: 373899210
Change-Id: I9908962949088356c2a61c1556183ccd5772985f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937903
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1370865}