Add test for RTCIceCandidatePair interface #46655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
reviewed
Jun 7, 2024
webrtc/idlharness.https.window.js
Outdated
| idlTestObjects.iceTransport = iceTransport; | ||
|
|
||
| const iceCandidatePair = iceTransport.getSelectedCandidatePair(); | ||
| assert_true(iceCandidatePair instanceof RTCIceCandidatePair, |
There was a problem hiding this comment.
For development, you should test that you get here and get a candidate pair - assert_not_null(iceCandidatePair).
think the test will only work if the candidate is selected before you get this far - which is timing dependent, but can't be depended on without waiting on a state change.
There was a problem hiding this comment.
indeed; amended the test to trigger and await the proper ice connection state
|
(this should probably wait for #46647 to be merged) |
alvestrand
approved these changes
Jun 7, 2024
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 18, 2024
…ce, a=testonly Automatic update from web-platform-tests Add test for RTCIceCandidatePair interface (#46655) * Add test for RTCIceCandidatePair interface see w3c/webrtc-pc#2978 * Fix test to wait for ICE connection per web-platform-tests/wpt#46655 (review) * Fix assert name -- wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c wpt-pr: 46655
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 19, 2024
…ce, a=testonly Automatic update from web-platform-tests Add test for RTCIceCandidatePair interface (#46655) * Add test for RTCIceCandidatePair interface see w3c/webrtc-pc#2978 * Fix test to wait for ICE connection per web-platform-tests/wpt#46655 (review) * Fix assert name -- wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c wpt-pr: 46655 UltraBlame original commit: 8c6ea51b01dcb2c252fb7e2fc73dc5bdefa2d350
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 19, 2024
…ce, a=testonly Automatic update from web-platform-tests Add test for RTCIceCandidatePair interface (#46655) * Add test for RTCIceCandidatePair interface see w3c/webrtc-pc#2978 * Fix test to wait for ICE connection per web-platform-tests/wpt#46655 (review) * Fix assert name -- wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c wpt-pr: 46655 UltraBlame original commit: 8c6ea51b01dcb2c252fb7e2fc73dc5bdefa2d350
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 21, 2024
…ce, a=testonly Automatic update from web-platform-tests Add test for RTCIceCandidatePair interface (#46655) * Add test for RTCIceCandidatePair interface see w3c/webrtc-pc#2978 * Fix test to wait for ICE connection per web-platform-tests/wpt#46655 (review) * Fix assert name -- wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c wpt-pr: 46655
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jun 24, 2024
…ce, a=testonly Automatic update from web-platform-tests Add test for RTCIceCandidatePair interface (#46655) * Add test for RTCIceCandidatePair interface see w3c/webrtc-pc#2978 * Fix test to wait for ICE connection per web-platform-tests/wpt#46655 (review) * Fix assert name -- wpt-commits: 7b74bc1d122c2d322329a25e0a6a99a4c2e9583c wpt-pr: 46655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see w3c/webrtc-pc#2978