Add missing casts and remove FloatMath methods calls #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanda1232
reviewed
Nov 4, 2020
Comment on lines
89
to
94
| float a = i * 3.1415926f * 2 / nRays; | ||
| v[0] = FloatMath.cos( a ) * radius; | ||
| v[1] = FloatMath.sin( a ) * radius; | ||
| v[0] = (float)Math.cos( a ) * radius; | ||
| v[1] = (float)Math.sin( a ) * radius; | ||
| vertices.put( v ); | ||
|
|
||
| a += 3.1415926f * 2 / nRays / 2; |
There was a problem hiding this comment.
Our static analysis engine detects that your pull request includes a change that uses the rough value of Math.PI. According to the best practice, it's recommended to use the predefined library constant for code clarity and better precision.
|
Good,But The Pixel Dungeon Not Update. |
Author
|
@LingASDJ yep, but maybe this code will help someone else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove compile errors on modern javac.
Note: android.util.FloatMath class was deprecated and all its methods was removed in API version 23 and above.
Also adding (Object) cast before
bundle.getCollection()call will supressIncompatible typeserror in Android Studio.