Add privacy protection to MerchantValidationEvent's validationURL #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsolomakhin
approved these changes
Mar 12, 2019
ianbjacobs
requested changes
Mar 12, 2019
There was a problem hiding this comment.
I agree with the sentiment, but two things make me uncomfortable:
- Imposing a normative requirement on payment handlers in this specification.
- It would probably be ok for the URL to include some information about a person for an authorized server; we don't want that information to be visible to unauthorized parties.
Proposed:
"It is important that the validationURL in a MerchantValidationEvent
does not expose personally identifying information to unauthorized parties."
I am avoiding creating a normative requirement, but do want to stress the importance.
|
@ianbjacobs, your suggestion sounds good. Could you please update this branch with your new text? |
|
Hi @marcoscaceres, I made the change and also did a tidy; I think some of the changes shown are due to tidy. Ian |
…into merchant_validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of PING discussions.
The following tasks have been completed:
Modified Web platform tests.Optional, impact on Payment Handler spec?
If handlers will have a means of handling merchant validation, that spec should include a privacy note.
Preview | Diff