这是indexloc提供的服务，不要输入任何密码
Skip to content

Set [[waitForUpdate]] to true on dispatch of payerdetailchange #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

Set [[waitForUpdate]] to true on dispatch of payerdetailchange #857

merged 1 commit into from
Apr 2, 2019

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Mar 31, 2019 •
edited by pr-preview bot
Loading

closes #854

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.
  • Modified Web platform tests
  • Modified MDN Docs (link)
  • Has undergone security/privacy review (link)

Implementation commitment:

  • Safari (link to issue)
  • Chrome
  • Firefox - already implemented.
  • Edge (public signal)

Optional, impact on Payment Handler spec?

Preview | Diff

@marcoscaceres marcoscaceres mentioned this pull request Mar 31, 2019
Merged
@marcoscaceres marcoscaceres requested a review from danyao March 31, 2019 06:44
romandev
romandev approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Apr 1, 2019
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 1, 2019
@romandev @chromium-wpt-export-bot
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event
5f5247e 
Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
danyao
danyao approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@danyao danyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcoscaceres
Copy link
Member Author

@romandev or @danyao, thanks for the review! Will merge, but could you please link to a Chrome bug for tracking purposes above?

@marcoscaceres marcoscaceres merged commit 0358fb3 into gh-pages Apr 2, 2019
@marcoscaceres marcoscaceres deleted the bug_fix branch April 2, 2019 02:44
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 2, 2019
@romandev @chromium-wpt-export-bot
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event
d4de0d3 
Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
@romandev
Copy link
Member

romandev commented Apr 2, 2019

https://bugs.chromium.org/p/chromium/issues/detail?id=947938

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 2, 2019
@romandev @chromium-wpt-export-bot
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event
01ff2e8 
Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 3, 2019
@romandev @chromium-wpt-export-bot
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event
3dc9bc6 
Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
@rsolomakhin
Copy link
Collaborator

Thank you @romandev! We missed you at the face-to-face :-D

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 4, 2019
@romandev @chromium-wpt-export-bot
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event
fb9eccd 
Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#647643}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 4, 2019
@romandev @chromium-wpt-export-bot
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event
50dc1c1 
Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#647643}
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 4, 2019
@romandev
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event
2d14bff 
Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#647643}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 5, 2019
@romandev @jgraham
Bug 1541993 [wpt PR 16172] - PaymentRequest: Set [[waitForUpdate]] to…
02d47bb 
… true on payerdetailchange event, a=testonly

Automatic update from web-platform-tests
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event

Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#647643}

--

wpt-commits: 50dc1c1af003ac248f307c640698a826a3576d4a
wpt-pr: 16172
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jun 6, 2019
@romandev @jgraham
Bug 1541993 [wpt PR 16172] - PaymentRequest: Set [[waitForUpdate]] to…
2eb25c9 
… true on payerdetailchange event, a=testonly

Automatic update from web-platform-tests
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event

Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#647643}

--

wpt-commits: 50dc1c1af003ac248f307c640698a826a3576d4a
wpt-pr: 16172
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
@romandev
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event
1b60ce8 
Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#647643}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1541993 [wpt PR 16172] - PaymentRequest: Set [[waitForUpdate]] to…
a31686e 
… true on payerdetailchange event, a=testonly

Automatic update from web-platform-tests
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event

Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyaochromium.org>
Reviewed-by: Rouslan Solomakhin <rouslanchromium.org>
Commit-Queue: Jinho Bang <jinho.bangsamsung.com>
Cr-Commit-Position: refs/heads/master{#647643}

--

wpt-commits: 50dc1c1af003ac248f307c640698a826a3576d4a
wpt-pr: 16172

UltraBlame original commit: 3cb1467fa4fc3731336d4e1a17a4e9c2ff5942d3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1541993 [wpt PR 16172] - PaymentRequest: Set [[waitForUpdate]] to…
20f0f4c 
… true on payerdetailchange event, a=testonly

Automatic update from web-platform-tests
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event

Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyaochromium.org>
Reviewed-by: Rouslan Solomakhin <rouslanchromium.org>
Commit-Queue: Jinho Bang <jinho.bangsamsung.com>
Cr-Commit-Position: refs/heads/master{#647643}

--

wpt-commits: 50dc1c1af003ac248f307c640698a826a3576d4a
wpt-pr: 16172

UltraBlame original commit: 3cb1467fa4fc3731336d4e1a17a4e9c2ff5942d3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1541993 [wpt PR 16172] - PaymentRequest: Set [[waitForUpdate]] to…
145338f 
… true on payerdetailchange event, a=testonly

Automatic update from web-platform-tests
PaymentRequest: Set [[waitForUpdate]] to true on payerdetailchange event

Related spec change:
  w3c/payment-request#857

Bug: 947938
Change-Id: I2ad448768025677bc31aa50426f9ef3160aa9760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547475
Reviewed-by: Danyao Wang <danyaochromium.org>
Reviewed-by: Rouslan Solomakhin <rouslanchromium.org>
Commit-Queue: Jinho Bang <jinho.bangsamsung.com>
Cr-Commit-Position: refs/heads/master{#647643}

--

wpt-commits: 50dc1c1af003ac248f307c640698a826a3576d4a
wpt-pr: 16172

UltraBlame original commit: 3cb1467fa4fc3731336d4e1a17a4e9c2ff5942d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romandev romandev romandev approved these changes

@danyao danyao danyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[[waitForUpdate]] must be set to true always after dispatch.
4 participants
@marcoscaceres @romandev @rsolomakhin @danyao