Add ariaBrailleLabel and ariaBrailleRoleDescription ARIAMixin reflections #2039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelSumner
approved these changes
Sep 28, 2023
coryj627
approved these changes
Oct 2, 2023
|
Thanks for the +1 @MelSumner @coryj627 ! Is there anything more needed on my end to merge this PR? |
|
Nothing to add from me |
cookiecrook
approved these changes
Oct 24, 2023
|
Thanks for the reviews! Added links to the WPT PR and relevant WebKit and Firefox bugs. |
|
Is there anything left to do before this is merged? |
|
pinging @jnurthen @spectranaut - can we merge this or is 1.3 FPWD too close to the finish line? |
|
I think you can merge it. Please add to the changelog if you think it is non editorial. |
@jnurthen how do I do that? Just manually? (if so, @nolanlawson feel free to beat me to it.) |
|
Thanks for the merge! Could someone help review the WPT tests as well? 🙇 web-platform-tests/wpt#42751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following string reflections to ARIAMixin:
ariaBrailleLabel->aria-braillelabelariaBrailleRoleDescription->aria-brailleroledescriptionThese reflections are already implemented in Chromium (see here and here), but not yet in WebKit or Firefox.
The purpose of this PR is to align with the de-facto behavior of Chromium. I don't see a strong reason for the spec not to include these particular reflections. (If there is one, please let me know!)
See also: #923
PR tracking
Check these when the relevant issue or PR has been made, OR after you have confirmed the
related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the
Process Document or
Test Overview for more information.
Implementation tracking
Preview | Diff