Normatively define earliest epoch index in terms of maximum lookback #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharrison
approved these changes
Sep 25, 2025
Collaborator
|
This seems fine to me. I don't see any real reason why these should use different constants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the benefit of the previous non-normative guidance around how the earliest epoch index might be chosen was unclear, and made it hard to understand what was going on in the simulator with respect to expiry vs lookback. In particular, there was no indication of why implementations might want to vary this value by site, and the non-normative guidance didn't even suggest doing so.
Instead, we normatively define the earliest epoch index in terms of the maximum lookback to permit the full range of impressions to be queried using a maximal
lookbackDaysvalue.Preview | Diff