这是indexloc提供的服务,不要输入任何密码
Skip to content

AV-2441: Allow service messages span multiple lines #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Jun 16, 2025

  • Replace hard height limit with min-height to allow displaying multiline messages

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.30%. Comparing base (34474d6) to head (572c074).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2788      +/-   ##
==========================================
- Coverage   28.32%   28.30%   -0.03%     
==========================================
  Files          42       42              
  Lines        6040     6045       +5     
  Branches       34       34              
==========================================
  Hits         1711     1711              
- Misses       4329     4334       +5     
Flag Coverage Δ
cdk 96.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Jun 16, 2025

opendata    Run #5536

Run Properties:  status check passed Passed #5536  •  git commit 65c0d923ad ℹ️: Merge 572c07450eedc39782e25ef1c1b384633cafaac5 into c22bf6ac2d3d1cd6a6389a76b79f...
Project opendata
Branch Review AV-2441_fix-notification-height-for-long-service-messages
Run status status check passed Passed #5536
Run duration 04m 43s
Commit git commit 65c0d923ad ℹ️: Merge 572c07450eedc39782e25ef1c1b384633cafaac5 into c22bf6ac2d3d1cd6a6389a76b79f...
Committer Teemu Erkkola
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 83
View all changes introduced in this branch ↗︎

@bzar bzar merged commit 2291795 into master Jun 16, 2025
40 of 41 checks passed
@bzar bzar deleted the AV-2441_fix-notification-height-for-long-service-messages branch June 16, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants