这是indexloc提供的服务,不要输入任何密码
Skip to content

AV-2435: Handle ObjectNotFound exceptions in openness_score_avg #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Jun 11, 2025

  • handle ObjectNotFound exceptions from qa_package_openness_show by disregarding such cases in openness score average calculations
  • added type annotations and fixed various style issues

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 28.30%. Comparing base (e1bfdc8) to head (2a90d1d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...an/ckanext/ckanext-ytp_main/ckanext/ytp/reports.py 0.00% 29 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2779      +/-   ##
==========================================
+ Coverage   26.67%   28.30%   +1.63%     
==========================================
  Files          42       42              
  Lines        5849     6045     +196     
  Branches       34       34              
==========================================
+ Hits         1560     1711     +151     
- Misses       4289     4334      +45     
Flag Coverage Δ
cdk 96.47% <ø> (ø)
ckan 23.14% <0.00%> (+1.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Jun 11, 2025

opendata    Run #5531

Run Properties:  status check passed Passed #5531  •  git commit 44394d346e ℹ️: Merge 2a90d1dd524203edb47d66da215426ae2279c5b7 into e1bfdc82120d8149f792625c56b4...
Project opendata
Branch Review AV-2435_handle-report-openness-exception
Run status status check passed Passed #5531
Run duration 03m 57s
Commit git commit 44394d346e ℹ️: Merge 2a90d1dd524203edb47d66da215426ae2279c5b7 into e1bfdc82120d8149f792625c56b4...
Committer Teemu Erkkola
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 83
View all changes introduced in this branch ↗︎

@bzar bzar merged commit d2dc899 into master Jun 16, 2025
39 of 41 checks passed
@bzar bzar deleted the AV-2435_handle-report-openness-exception branch June 16, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants