fix: add missing OpenSSL dependency for building wws #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cross environment
assambar
approved these changes
Jan 26, 2023
Contributor
assambar
left a comment
There was a problem hiding this comment.
Great research and findings! Thanks for the detailed explanation!
ereslibre
approved these changes
Jan 26, 2023
Contributor
ereslibre
left a comment
There was a problem hiding this comment.
Thanks for the great research @Angelmmiguel! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix this error by installing the required dependencies following the recommendation in the openssl-sys crate. However, this only works for the
gnutooling. Since we're usingmuslfor compiling static binaries, we cannot rely on this solution.I tested the usage of rusttls instead of openssl. I couldn't make it work in Windows ARM64, as one of the dependencies (ring) is not compiling on that environment with the latest version. The team did an amazing job of supporting this platform and it's already fixed in upstream (See this PR). However, this version is not published yet. It seems they're planning to release the 0.16.21 it soon. Until this version is published, unfortunately we won't be able to swich to
rusttls.In the end, I used the
vendoredfeature from theopensslcrate in bothmusltarget. This feature compiles the OpenSSL library from source. I tested and it's properly working.You can find here a successful run, as I removed the PR trigger in the latest commit: https://github.com/vmware-labs/wasm-workers-server/actions/runs/4016745514
It closes #76