fix: normalize API routes using Rust path entities #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I found an error when testing subfolders in Windows. It's using the |
ereslibre
reviewed
Nov 18, 2022
Contributor
ereslibre
left a comment
There was a problem hiding this comment.
Looking great, lots of tests! A couple of comments :)
…ions into a single one.
ereslibre
approved these changes
Nov 18, 2022
Contributor
ereslibre
left a comment
There was a problem hiding this comment.
LGTM, thanks @Angelmmiguel! It looks great! Just a small optional comment about the GH workflow setup
ereslibre
reviewed
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current
mainversion, file paths are not normalized properlies as APIs. This is causing inconsistent behaviors in different environments:wws ./examples/js-basic, the URL of thehandler.jsshould be/handler. Note that./examples/js-basicis the local folder to read the files, not a prefix for the final URL. However, the HTTP endpoint it generates is `/examples/js-basic/handler.handler.jsis not accessible (See [1]).This is mainly caused by converting file paths to string and apply transformations later. Since paths may include special components such as
.and./, applying operations likereplacecan have different outcomes depending on the environment. This also causes inconsistent behaviors when a final backslash is added or not to the CLI argument.In this PR, I changed that implementation to run all required transformations directly on the path. Instead of replacing and subtracting from a converted string, I iterate over the components to remove any special entity and keep only the Normal ones. Finally, I convert them to a String to be used as the API path.
I tested the current changes on both Windows and Mac (Unix) and they work great:
[1]
It closes #30