这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: show stack traces when capturing errors in the handler #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat: show stack traces when capturing errors in the handler #247

merged 1 commit into from
Oct 20, 2023

Conversation

@Angelmmiguel
Copy link
Contributor

@Angelmmiguel Angelmmiguel commented Oct 20, 2023

Display JS stack traces when there's an error:

Before

There was an error running the handler:
TypeError: not a function

After

There was an error running the handler:
TypeError: not a function
    at errorHandler (handler.mjs:3748)
    at handleError (handler.mjs:3914)
    at dispatch (handler.mjs:3938)
    at <anonymous> (handler.mjs:3768)
    at <anonymous> (runtime.mjs)
    at requestToHandler (handler.mjs:2962)

It closes #246

@Angelmmiguel Angelmmiguel added 🚀 enhancement New feature or request 🔨 sdks Issues related to language SDKs labels Oct 20, 2023
@Angelmmiguel Angelmmiguel added this to the 1.7.0 milestone Oct 20, 2023
@Angelmmiguel Angelmmiguel requested a review from a team October 20, 2023 07:01
@Angelmmiguel Angelmmiguel self-assigned this Oct 20, 2023
ereslibre
ereslibre approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Angelmmiguel Angelmmiguel merged commit 582ba99 into main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ereslibre ereslibre ereslibre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Angelmmiguel Angelmmiguel

Labels

cla-not-required 🚀 enhancement New feature or request 🔨 sdks Issues related to language SDKs

Projects

None yet

Milestone

v1.7.0

Development

Successfully merging this pull request may close these issues.

Display JavaScript stack traces when printing the errors

4 participants

@Angelmmiguel @ereslibre @vmwclabot