这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ereslibre
Copy link
Contributor

No description provided.


// prepare writer for json
var out_buf: [1024]u8 = undefined;
var out_buf: [4096]u8 = undefined;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this merges I'm going to open an issue to need an allocator here instead of fixed sizes on the stack.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

var enc = std.base64.Base64Encoder.init(std.base64.standard_alphabet_chars, '=');
var data_len = enc.calcSize(data.len);
var buf: [128]u8 = undefined;
var buf: [16384]u8 = undefined;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this merges I'm going to open an issue to need an allocator here instead of fixed sizes on the stack.

Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


// prepare writer for json
var out_buf: [1024]u8 = undefined;
var out_buf: [4096]u8 = undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@ereslibre ereslibre merged commit be17854 into vmware-labs:main Sep 14, 2023
@ereslibre ereslibre deleted the zig-mount branch September 14, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants