feat(server): add --cors argument to enable cors for all workers
#202
Conversation
|
@Narayanbhat166, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@Narayanbhat166, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@Narayanbhat166, VMware has approved your signed contributor license agreement. |
Angelmmiguel
left a comment
There was a problem hiding this comment.
Hey @Narayanbhat166!
Thank you very much for your contribution 🎉 . The code LGTM!
I'm gonna merge it right after tests passes. We will need to rebase this change into #185, as we're consolidating all app_data into a single structure. @ereslibre will consolidate it in that PR.
Thank you! 👏
This PR will add the support for configuring origins to enable CORS for all the workers. If the worker has setup
Access-Control-Allow-Originthen it will be respected. Multiple origins can be passed using the--corsflag. This is a simple examplewws --cors https://example.com .This will add
https://example.comto all the workers who do not haveAccess-Control-Allow-Originheader configured. This can be tested out by the below curl commandTo enable all origins, wws can be run with the argument
Closes #46