feat: manage static assets properly in Unix and Windows #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
reviewed
Oct 5, 2023
Contributor
ereslibre
left a comment
There was a problem hiding this comment.
Thanks a lot for taking care of this and for adding a nice amount of tests.
Just a comment, I know actix filters this for us now, but I wonder about the logic itself, if we cannot rely on that filtering.
ereslibre
pushed a commit
that referenced
this pull request
Oct 5, 2023
* feat: manage static assets properly in Unix and Windows * feat: add more e2e tests to validate static assets
Angelmmiguel
added a commit
that referenced
this pull request
Oct 6, 2023
* feat: manage static assets properly in Unix and Windows * feat: add more e2e tests to validate static assets
Angelmmiguel
added a commit
that referenced
this pull request
Oct 6, 2023
* feat: manage static assets properly in Unix and Windows * feat: add more e2e tests to validate static assets
Angelmmiguel
added a commit
that referenced
this pull request
Oct 6, 2023
* feat: manage static assets properly in Unix and Windows * feat: add more e2e tests to validate static assets
Angelmmiguel
added a commit
that referenced
this pull request
Oct 6, 2023
* feat: manage static assets properly in Unix and Windows * feat: add more e2e tests to validate static assets
Angelmmiguel
added a commit
that referenced
this pull request
Oct 6, 2023
* feat: manage static assets properly in Unix and Windows * feat: add more e2e tests to validate static assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since URIs use
/as the separator,wwsdidn't return static assets in a subfolder in Windows. I took the opportunity to refactor part of the code and add tests to ensurewwscalculates asset paths properly. For that, I split the process into different steps:publicfolder that points to a possible static assetI included a battery of tests for those methods and I'm planning to add some e2e tests for static assets.