这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: update Dockerfile #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix: update Dockerfile #187

merged 1 commit into from
Jul 25, 2023

Conversation

@dierbei
Copy link
Contributor

@dierbei dierbei commented Jul 25, 2023 •
edited by ereslibre
Loading

I increased the ENTRYPOINT in the Dockerfile to default to the path to the wws executable.

And the CMD command can override the default value when running the image.

Fixes: #166

@vmwclabot
Copy link

vmwclabot commented Jul 25, 2023

@dierbei, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

vmwclabot commented Jul 25, 2023

@dierbei, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link

vmwclabot commented Jul 25, 2023

@dierbei, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide a valid email address

@vmwclabot
Copy link

vmwclabot commented Jul 25, 2023

@dierbei, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

ereslibre
ereslibre suggested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @dierbei! A couple of comments before we can merge it :)

@vmwclabot
Copy link

vmwclabot commented Jul 25, 2023

@dierbei, VMware has approved your signed contributor license agreement.

@dierbei dierbei force-pushed the update-dockerfile branch from 1d75970 to cc58188 Compare July 25, 2023 08:22
ereslibre
ereslibre approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dierbei! 👏

@ereslibre ereslibre merged commit be9e355 into vmware-labs:main Jul 25, 2023
@ereslibre ereslibre mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ereslibre ereslibre ereslibre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify how you run wws commands in the container

3 participants

@dierbei @vmwclabot @ereslibre