这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@assambar
Copy link
Contributor

@assambar assambar commented Oct 19, 2022

  • Added code to build a multi-arch image
  • Updated README and docs with info about said image (already published)

It closes #11

Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @assambar! Just a minor wording suggestion.

Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great!! I just added some minor comments @assambar. Only one applies to this PR, the other can be done in a separate one. I already approved it, so we can squash and merge right after.

Thanks!

@assambar assambar merged commit 14a624f into main Nov 10, 2022
@assambar assambar deleted the build-images branch November 10, 2022 14:20
@assambar
Copy link
Contributor Author

#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a container image and build it

5 participants