feat: add the fetch and more APIs to the JavaScript kit #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68f91f0 to
0d501eb
Compare
ereslibre
reviewed
Jul 5, 2023
Contributor
ereslibre
left a comment
There was a problem hiding this comment.
LGTM! A couple minor comments.
0d501eb to
c51311f
Compare
6 tasks
c51311f to
5023752
Compare
ereslibre
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #168. We will need to merge and rebase this branch before
The goal of this PR is to introduce more methods and common APIs to the JavaScript kit. It introduces the following APIs:
fetchconsoleURLSearchParamsTextEncoderandTextDecoderResponseimplementationIt refs #165
Building the shim
Before, the shim was a single
glue.jsfile. All JavaScript code was hardcoded as we were not using any bundling system. To start using external libraries, I added esbuild, a fast bundler for JavaScript. The shim code is available in thekits/javascript/shimsfolder and it contains all the files and references different external libraries.As part of the build process of the JS engine, it builds the shim and injects it in the final Wasm module.
External libraries
To avoid re-implementing all these APIs manually, we are using existing libraries: