这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: pass the root_path as shared data in actix #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix: pass the root_path as shared data in actix #114

merged 1 commit into from
Mar 16, 2023

Conversation

@Angelmmiguel
Copy link
Contributor

@Angelmmiguel Angelmmiguel commented Mar 15, 2023

Ensure the root_path property is passed as a Actix data to the handlers. I also fixed the type to the right one. After applying it, wws is properly returning the 404 or the static asset:

Favicon.ico is missing

⚙️  Loading routes from: ./examples/js-basic
🗺  Detected routes:
    - http://127.0.0.1:9090/
      => ./examples/js-basic/index.js (name: default)
🚀 Start serving requests at http://127.0.0.1:9090

[2023-03-15T16:19:15Z INFO  actix_web::middleware::logger] 127.0.0.1 "GET / HTTP/1.1" 200 827 "-" "..." 0.028136
[2023-03-15T16:19:15Z INFO  actix_web::middleware::logger] 127.0.0.1 "GET /favicon.ico HTTP/1.1" 404 0 "http://localhost:9090/" "..." 0.001388

Favicon.ico is present

⚙️  Loading routes from: ./examples/js-basic
🗺  Detected routes:
    - http://127.0.0.1:9090/
      => ./examples/js-basic/index.js (name: default)
🚀 Start serving requests at http://127.0.0.1:9090

[2023-03-15T16:19:15Z INFO  actix_web::middleware::logger] 127.0.0.1 "GET / HTTP/1.1" 200 827 "-" "..." 0.028136
[2023-03-15T16:20:44Z INFO  actix_web::middleware::logger] 127.0.0.1 "GET /favicon.ico HTTP/1.1" 200 15406 "http://localhost:9090/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/109.0" 0.005634

It closes #111

@Angelmmiguel Angelmmiguel added the 🐛 bug Something isn't working label Mar 15, 2023
@Angelmmiguel Angelmmiguel added this to the v1.1.0 milestone Mar 15, 2023
@Angelmmiguel Angelmmiguel requested a review from a team March 15, 2023 16:24
@Angelmmiguel Angelmmiguel self-assigned this Mar 15, 2023
@Angelmmiguel Angelmmiguel merged commit 570544c into main Mar 16, 2023
@Angelmmiguel Angelmmiguel deleted the 111-error-handling-assets branch May 8, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ereslibre ereslibre ereslibre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Angelmmiguel Angelmmiguel

Labels

🐛 bug Something isn't working cla-not-required

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

Error when accessing a non existing URL

4 participants

@Angelmmiguel @ereslibre @vmwclabot