Make exec timeout configurable #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpuguy83 PTAL |
|
Thanks! One thing I'd like is if this can be changed so we aren't breaking callers of these functions. |
I have updated the PR, thanks |
cpuguy83
reviewed
Jan 16, 2020
node/api/server.go
Outdated
| @@ -39,7 +39,7 @@ type PodHandlerConfig struct { | |||
| } | |||
|
|
|||
| // PodHandler creates an http handler for interacting with pods/containers. | |||
| func PodHandler(p PodHandlerConfig, debug bool) http.Handler { | |||
| func PodHandler(p PodHandlerConfig, debug bool, cfg ...StreamTimeOutConfig) http.Handler { | |||
There was a problem hiding this comment.
Sorry I was thinking something like functional options so ...func(*Config) And then you can provide a list of functions to set the config... e.g. WithStreamIdleTimeout(dur).
But looking at the underlying code again, I think we could probably just add a stream config to the PodHandlerConfig
29eac4c to
493f029
Compare
493f029 to
ed63b5e
Compare
cpuguy83
requested changes
Jan 17, 2020
Co-Authored-By: Brian Goff <cpuguy83@gmail.com>
|
Updated |
a701c8c to
9eb591e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make exec timeout configurable
See
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/config/types.go#L165
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kubelet.go#L2296
kubelet also allows to change default steamIdleTimeout, so I think it's to reasonable to make it configurable
Fix: #791