After handling status update, reset update timer with correct duration #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
requested changes
Nov 10, 2019
node/node.go
Outdated
| @@ -259,10 +259,13 @@ func (n *NodeController) controlLoop(ctx context.Context) error { | |||
| return nil | |||
| case updated := <-n.chStatusUpdate: | |||
| var t *time.Timer | |||
| var resetDuration time.Duration | |||
There was a problem hiding this comment.
Maybe we can set this before we start the loop?
There was a problem hiding this comment.
I've made this change in the new commit, please take a look.
Personally I think it was more obvious why the reset duration had to be changed when it was bundled with this
Lines 262 to 266 in ba940a9
logic.
Maybe selecting the active timer could be moved out of the loop as well?
8180607 to
fb6e9c6
Compare
|
@cpuguy83 I've pushed a new commit with a test that shows this. Without the fix (ping timer is reset to status timer interval): With the fix: |
fb6e9c6 to
8e79bb5
Compare
If the ping timer is being used, it should be reset with the ping update interval. If the status update interval is used then Ping stops being called for long enough to cause kubernetes to mark the node as NotReady.
8e79bb5 to
c258614
Compare
cpuguy83
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ping timer is being used, it should be reset with the ping update
interval. If the status update interval is used then Ping stops being
called for long enough to cause kubernetes to mark the node as NotReady.
Fixes #788