fix: Handle response error when nil #709

helayoty · 2025-06-17T22:22:21Z

In GetACISubnet function, the response error is not handled by errors.As(err, &respErr), which will cause nil pointer dereference when the response error is nil.
runtime.WithCaptureResponse is deprecated in favor of policy.WithCaptureResponse

codecov · 2025-06-17T22:24:43Z

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 58.53%. Comparing base (b3460ff) to head (e9c4e2c).
Report is 72 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/client/client_apis.go	0.00%	17 Missing ⚠️
pkg/network/aci_network.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #709       +/-   ##
===========================================
- Coverage   69.81%   58.53%   -11.28%     
===========================================
  Files          15       25       +10     
  Lines        2597     3806     +1209     
===========================================
+ Hits         1813     2228      +415     
- Misses        666     1436      +770     
- Partials      118      142       +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

This PR updates error handling in GetACISubnet to guard against nil response errors and replaces deprecated runtime.WithCaptureResponse calls with policy.WithCaptureResponse across client methods.

Added a nil check for respErr.RawResponse in GetACISubnet to prevent nil pointer dereference.
Replaced all runtime.WithCaptureResponse usages with the new policy.WithCaptureResponse API.
Updated imports to remove the deprecated runtime package and adjust grouping.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pkg/network/aci_network.go	Guarded against nil `respErr.RawResponse` and switched to `policy.WithCaptureResponse`
pkg/client/client_apis.go	Replaced `runtime.WithCaptureResponse` with `policy.WithCaptureResponse` and tweaked error checks

Comments suppressed due to low confidence (1)

pkg/network/aci_network.go:217

[nitpick] Consider adding a unit test for the case where respErr.RawResponse is nil in GetACISubnet to verify that the function does not panic and returns the expected error.

			respErr.RawResponse != nil &&

Copilot · 2025-06-17T22:54:14Z

pkg/client/client_apis.go

+		if errors.As(err, &rawResponse) &&
+			rawResponse.StatusCode == http.StatusNotFound {


Using errors.As to match *http.Response will always fail since err is not a *http.Response. Replace this condition with: if rawResponse != nil && rawResponse.StatusCode == http.StatusNotFound.

Suggested change

if errors.As(err, &rawResponse) &&

rawResponse.StatusCode == http.StatusNotFound {

if rawResponse != nil && rawResponse.StatusCode == http.StatusNotFound {

Copilot · 2025-06-17T22:54:15Z

pkg/client/client_apis.go

+		if errors.As(err, &rawResponse) &&
+			rawResponse != nil && rawResponse.StatusCode == http.StatusNotFound {


errors.As cannot extract *http.Response from err. Change this check to if rawResponse != nil && rawResponse.StatusCode == http.StatusNotFound to correctly detect NotFound responses.

Suggested change

if errors.As(err, &rawResponse) &&

rawResponse != nil && rawResponse.StatusCode == http.StatusNotFound {

if rawResponse != nil && rawResponse.StatusCode == http.StatusNotFound {

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

…sCode Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>

helayoty requested a review from Copilot June 17, 2025 22:22

helayoty requested review from Fei-Guo and smritidahal653 as code owners June 17, 2025 22:22

helayoty added the kind/bug Something isn't working label Jun 17, 2025

helayoty temporarily deployed to test June 17, 2025 22:22 — with GitHub Actions Inactive

helayoty had a problem deploying to test June 17, 2025 22:22 — with GitHub Actions Failure

This comment was marked as outdated.

Sign in to view

helayoty temporarily deployed to test June 17, 2025 22:35 — with GitHub Actions Inactive

helayoty had a problem deploying to test June 17, 2025 22:35 — with GitHub Actions Failure

helayoty requested a review from Copilot June 17, 2025 22:35

This comment was marked as outdated.

Sign in to view

helayoty had a problem deploying to test June 17, 2025 22:38 — with GitHub Actions Failure

helayoty temporarily deployed to test June 17, 2025 22:38 — with GitHub Actions Inactive

helayoty force-pushed the helayoty/fix-resp-err branch from 2b7cb64 to ea9fb7b Compare June 17, 2025 22:50

helayoty temporarily deployed to test June 17, 2025 22:50 — with GitHub Actions Inactive

helayoty had a problem deploying to test June 17, 2025 22:50 — with GitHub Actions Failure

helayoty requested a review from Copilot June 17, 2025 22:50

This comment was marked as outdated.

Sign in to view

helayoty requested a review from Copilot June 17, 2025 22:53

Copilot AI reviewed Jun 17, 2025

View reviewed changes

helayoty force-pushed the helayoty/fix-resp-err branch from ea9fb7b to 96f8828 Compare June 20, 2025 19:30

helayoty temporarily deployed to test June 20, 2025 19:30 — with GitHub Actions Inactive

helayoty had a problem deploying to test June 20, 2025 19:30 — with GitHub Actions Failure

helayoty and others added 3 commits June 24, 2025 18:32

Handle response error when nil

e292222

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

Ensure that rawResponse is not nil before accessing rawResponse.Statu…

1351141

…sCode Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>

Ensure that respErr is not nil before accessing rawResponse.StatusCode

e9c4e2c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>

helayoty force-pushed the helayoty/fix-resp-err branch from 96f8828 to e9c4e2c Compare June 25, 2025 01:33

helayoty had a problem deploying to test June 25, 2025 01:33 — with GitHub Actions Failure

helayoty temporarily deployed to test June 25, 2025 01:33 — with GitHub Actions Inactive

helayoty closed this Jun 25, 2025

helayoty had a problem deploying to test June 25, 2025 01:37 — with GitHub Actions Error

helayoty temporarily deployed to test June 25, 2025 01:37 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Handle response error when nil #709

fix: Handle response error when nil #709

Uh oh!

helayoty commented Jun 17, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jun 17, 2025

Uh oh!

Copilot AI Jun 17, 2025

Uh oh!

Uh oh!

		if errors.As(err, &rawResponse) &&
		rawResponse.StatusCode == http.StatusNotFound {

	if errors.As(err, &rawResponse) &&
	rawResponse.StatusCode == http.StatusNotFound {
	if rawResponse != nil && rawResponse.StatusCode == http.StatusNotFound {

		if errors.As(err, &rawResponse) &&
		rawResponse != nil && rawResponse.StatusCode == http.StatusNotFound {

fix: Handle response error when nil #709

fix: Handle response error when nil #709

Uh oh!

Conversation

helayoty commented Jun 17, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jun 17, 2025 •

edited

Loading