这是indexloc提供的服务，不要输入任何密码
Skip to content

chore(signals): prefactor #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 27, 2025
Merged

chore(signals): prefactor #9995

merged 9 commits into from
Feb 27, 2025

Conversation

@chris-olszewski
Copy link
Contributor

@chris-olszewski chris-olszewski commented Feb 17, 2025

Description

Prefactors:

  • moved signal listening to own crate
  • return signal received to subscribers
  • support streams instead of single futures for signal sources

PR that prefactors the signals code to prepare for:

  • Subscribers getting all signals sent to turbo
  • Additional signal handlers to be sent transparently to children

There are no behavior changes in this PR. I highly suggest reviewing each commit on its own.

Testing Instructions

Existing unit tests.

Quick manual verification that existing SIGINT behavior remains the same:

$ turbo_dev watch build
...
│    Finalizing page optimization  .   Collecting build traces  .
└────>
  × Watch interrupted due to signal

@chris-olszewski chris-olszewski requested a review from a team as a code owner February 17, 2025 20:09
@vercel
Copy link
Contributor

vercel bot commented Feb 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:57pm

@chris-olszewski chris-olszewski marked this pull request as draft February 18, 2025 14:03
@chris-olszewski chris-olszewski marked this pull request as ready for review February 21, 2025 13:59
@chris-olszewski chris-olszewski force-pushed the olszewski/chore_signal_prefactor branch from d6e0fd4 to 3f88707 Compare February 27, 2025 17:56
@chris-olszewski chris-olszewski merged commit 51c8361 into main Feb 27, 2025
38 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_signal_prefactor branch February 27, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

1 more reviewer

@NicholasLYang NicholasLYang NicholasLYang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chris-olszewski @NicholasLYang