这是indexloc提供的服务，不要输入任何密码
Skip to content

chore: standardize type check job name to check-types #9973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2025
Merged

chore: standardize type check job name to check-types #9973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e84103
Standard type check job name to check-types
Asupkay Feb 14, 2025
33aa241
Modify with-gatsby's check types command
Asupkay Feb 14, 2025
2ed4287
Move with-vue-nuxt to check-types
Asupkay Feb 14, 2025
fca926e
Merge branch 'main' into check-types
Asupkay Feb 14, 2025
1477000
Merge branch 'main' into check-types
anthonyshew Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/with-gatsby/apps/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dev": "gatsby develop",
"build": "gatsby build",
"start": "gatsby develop",
"typecheck": "tsc --noEmit",
"check-types": "tsc --noEmit",
"lint": "eslint src/ --max-warnings 0"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion examples/with-shell-commands/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ This Turborepo includes the following packages:

If you haven't yet, [install global `turbo`](https://turbo.build/repo/docs/installing#install-globally) to run tasks.

- `turbo build lint type-check`: Runs all tasks in the default graph.
- `turbo build lint check-types`: Runs all tasks in the default graph.
- `turbo build`: A basic command to build `app-a` and `app-b` in parallel.
- `turbo build --filter=app-a`: Building only `app-a` and its dependencies.
- `turbo lint`: A basic command for running lints in all packages in parallel.
2 changes: 1 addition & 1 deletion examples/with-shell-commands/apps/app-a/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"scripts": {
"build": "mkdir -p dist && echo \"Your application output!\" > dist/app-output.txt && echo \"Application A is built!\"",
"lint": "echo \"Linted!\"",
"type-check": "echo \"Types checked!\""
"check-types": "echo \"Types checked!\""
},
"dependencies": {
"pkg-a": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion examples/with-shell-commands/apps/app-b/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"scripts": {
"build": "mkdir -p dist && echo \"Your application output!\" > dist/app-output.txt && echo \"Application B is built!\"",
"lint": "echo \"Linted!\"",
"type-check": "echo \"Types checked!\""
"check-types": "echo \"Types checked!\""
},
"dependencies": {
"tooling-config": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion examples/with-shell-commands/packages/pkg-a/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"scripts": {
"build": "echo \"Building at the speed of Turbo.\" > output-file.txt && cat output-file.txt",
"lint": "echo \"Linted!\"",
"type-check": "echo \"Types checked!\""
"check-types": "echo \"Types checked!\""
},
"dependencies": {
"tooling-config": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion examples/with-shell-commands/packages/pkg-b/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"scripts": {
"prebuild": "echo \"Executing pre-build step...\"",
"build": "echo \"Welcome to the Turboverse.\" > output-file.txt && cat output-file.txt",
"type-check": "echo \"Types checked!\""
"check-types": "echo \"Types checked!\""
},
"dependencies": {
"tooling-config": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion examples/with-shell-commands/turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
},
"prebuild": {},
"lint": {},
"type-check": {}
"check-types": {}
}
}
2 changes: 1 addition & 1 deletion examples/with-typeorm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"build": "turbo run build",
"dev": "turbo run dev",
"lint": "turbo run lint",
"type-check": "turbo run type-check",
"check-types": "turbo run check-types",
"format": "prettier --write \"**/*.{ts,tsx,md}\""
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion examples/with-typeorm/packages/typeorm-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"lint": "eslint src/ --max-warnings 0",
"test:watch": "vitest",
"test": "vitest run",
"type-check": "tsc --noEmit"
"check-types": "tsc --noEmit"
},
"peerDependencies": {
"typeorm": "^0.3.20"
Expand Down
2 changes: 1 addition & 1 deletion examples/with-typeorm/turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"lint": {
"dependsOn": ["^lint"]
},
"type-check": {},
"check-types": {},
"test": {
"cache": false,
"inputs": ["**/*.test.ts", "**/*.test.tsx", "vitest.config.ts"]
Expand Down
4 changes: 2 additions & 2 deletions examples/with-vue-nuxt/apps/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
"private": true,
"scripts": {
"dev": "vite --port 3000",
"build": "run-p type-check \"build-only {@}\" --",
"build": "run-p check-types \"build-only {@}\" --",
"preview": "vite preview",
"build-only": "vite build",
"type-check": "vue-tsc --noEmit -p tsconfig.app.json --composite false",
"check-types": "vue-tsc --noEmit -p tsconfig.app.json --composite false",
"lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore"
},
"dependencies": {
Expand Down
Loading