这是indexloc提供的服务,不要输入任何密码
Skip to content

chore: standardize type check job name to check-types #9973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

Asupkay
Copy link
Contributor

@Asupkay Asupkay commented Feb 14, 2025

Description

This pull request standardizes the type checking task name to check-types across all example repos. This is good so that new users can learn one way and feel confident they will be able to run this across all repos that need it.

Testing Instructions

Running turbo check-types in with-shell-commands example

Screenshot 2025-02-14 at 12 34 21 PM

Running pnpm check-types in with-typeorm repo

Screenshot 2025-02-14 at 12 34 33 PM

Running pnpm check-types in with-gatsby/apps/web
Screenshot 2025-02-14 at 12 43 06 PM

Running pnpm check-types and pnpm build in with-vue-next/apps/web
Screenshot 2025-02-14 at 12 44 23 PM

@Asupkay Asupkay requested a review from a team as a code owner February 14, 2025 17:44
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Feb 14, 2025
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:36pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:36pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:36pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:36pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:36pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:36pm

Copy link

vercel bot commented Feb 14, 2025

@Asupkay is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@anthonyshew anthonyshew enabled auto-merge (squash) February 14, 2025 22:36
@anthonyshew anthonyshew merged commit 8e8c6b7 into vercel:main Feb 14, 2025
27 of 30 checks passed
joshnuss pushed a commit to joshnuss/turborepo that referenced this pull request Feb 15, 2025
### Description

This pull request standardizes the type checking task name to
`check-types` across all example repos. This is good so that new users
can learn one way and feel confident they will be able to run this
across all repos that need it.

### Testing Instructions

Running `turbo check-types` in `with-shell-commands` example

![Screenshot 2025-02-14 at 12 34
21 PM](https://github.com/user-attachments/assets/5252ab8d-8d30-423a-abd5-39e5451ead24)

Running `pnpm check-types` in `with-typeorm` repo

![Screenshot 2025-02-14 at 12 34
33 PM](https://github.com/user-attachments/assets/b3ea332f-915d-472f-a36b-e7f5d7f76207)

Running `pnpm check-types` in `with-gatsby/apps/web`
![Screenshot 2025-02-14 at 12 43
06 PM](https://github.com/user-attachments/assets/c09a36f9-a6df-4e2f-adea-bc062ff2a181)


Running `pnpm check-types` and `pnpm build` in `with-vue-next/apps/web` 
![Screenshot 2025-02-14 at 12 44
23 PM](https://github.com/user-attachments/assets/953348d2-8e8b-4759-be3a-cdcc4d469bbd)

---------

Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants