这是indexloc提供的服务,不要输入任何密码
Skip to content

chore: standardize how turbo is ran in example packages #9970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Asupkay
Copy link
Contributor

@Asupkay Asupkay commented Feb 14, 2025

Description

This pull request goes through and makes sure each example uses "turbo run x" instead of "turbo x". I did this as in the docs it says "We recommend using turbo run in CI pipelines and turbo with global turbo locally for ease of use". In the examples some packages were one way, others the opposite, some mixed. Since these command will be run by proxy by pipelines it would be good to standardize across the board to turbo run.

Testing Instructions

I went through each package where there were changes and ran every command.

@Asupkay Asupkay requested a review from a team as a code owner February 14, 2025 16:11
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Feb 14, 2025
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:01pm

Copy link

vercel bot commented Feb 14, 2025

@Asupkay is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Forgot to do this. Thank you!

@anthonyshew anthonyshew merged commit 623f61c into vercel:main Feb 14, 2025
31 of 32 checks passed
joshnuss pushed a commit to joshnuss/turborepo that referenced this pull request Feb 15, 2025
### Description

This pull request goes through and makes sure each example uses "turbo
run _x_" instead of "turbo _x_". I did this as [in the
docs](https://turbo.build/repo/docs/reference/run) it says "We recommend
using `turbo run` in CI pipelines and `turbo` with global turbo locally
for ease of use". In the examples some packages were one way, others the
opposite, some mixed. Since these command will be run by proxy by
pipelines it would be good to standardize across the board to `turbo
run`.

### Testing Instructions

I went through each package where there were changes and ran every
command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants