这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: adds pnpm lockfile ignoredOptionalDependencies #9939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ragrag
Copy link
Contributor

@ragrag ragrag commented Feb 11, 2025

Description

Adds pnpm lockfile ignoredOptionalDependencies

I'm unaware if i need to make changes anywhere else, this works as expected in e.g copying lockfile during pruning

Fixes: #8959

@ragrag ragrag requested a review from a team as a code owner February 11, 2025 14:49
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Feb 11, 2025
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:51pm

Copy link

vercel bot commented Feb 11, 2025

@ragrag is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I believe you're correct that this is all that's required. The pnpm-lock.yaml we're pruning should have omitted any of the ignored optional dependencies so we wouldn't have the chance to copy them over.

@vercel vercel bot temporarily deployed to Preview – examples-nonmonorepo February 11, 2025 17:51 Inactive
@chris-olszewski chris-olszewski merged commit 73ca5fc into vercel:main Feb 11, 2025
37 of 38 checks passed
joshnuss pushed a commit to joshnuss/turborepo that referenced this pull request Feb 15, 2025
### Description

Adds pnpm lockfile ignoredOptionalDependencies

I'm unaware if i need to make changes anywhere else, this works as
expected in e.g copying lockfile during pruning

Fixes: vercel#8959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pnpm.ignoreOptionalDependencies when pruning lockfile
2 participants