-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(colors): add options for forcing color/no-color #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
package ui | ||
|
||
import ( | ||
"os" | ||
|
||
"github.com/fatih/color" | ||
) | ||
|
||
type ColorMode int | ||
|
||
const ( | ||
ColorModeUndefined ColorMode = iota + 1 | ||
ColorModeSuppressed | ||
ColorModeForced | ||
) | ||
|
||
func GetColorModeFromEnv() ColorMode { | ||
// The FORCED_COLOR behavior and accepted values are taken from the supports-color NodeJS Package: | ||
// The accepted values as documented are "0" to disable, and "1", "2", or "3" to force-enable color | ||
// at the specified support level (1 = 16 colors, 2 = 256 colors, 3 = 16M colors). | ||
// We don't currently use the level for anything specific, and just treat things as on and off. | ||
// | ||
// Note: while "false" and "true" aren't documented, the library coerces these values to 0 and 1 | ||
// respectively, so that behavior is reproduced here as well. | ||
// https://www.npmjs.com/package/supports-color | ||
|
||
switch forcedColor := os.Getenv("FORCED_COLOR"); { | ||
thebanjomatic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
case forcedColor == "false" || forcedColor == "0": | ||
return ColorModeSuppressed | ||
case forcedColor == "true" || forcedColor == "1" || forcedColor == "2" || forcedColor == "3": | ||
return ColorModeForced | ||
default: | ||
return ColorModeUndefined | ||
} | ||
} | ||
|
||
func applyColorMode(colorMode ColorMode) ColorMode { | ||
switch colorMode { | ||
case ColorModeForced: | ||
color.NoColor = false | ||
case ColorModeSuppressed: | ||
color.NoColor = true | ||
case ColorModeUndefined: | ||
default: | ||
// color.NoColor already gets its default value based on | ||
// isTTY and/or the presence of the NO_COLOR env variable. | ||
} | ||
|
||
if color.NoColor { | ||
return ColorModeSuppressed; | ||
} else { | ||
return ColorModeForced; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the positional arguments were being passed in before:
This now gets sent as:
Likely a change in behavior when switching to pnpm from yarn