refactor(spaces): no more spaces #9961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NicholasLYang
commented
Feb 13, 2025
| @@ -401,33 +401,33 @@ mod test { | |||
|
|
|||
| unset_tests! { | |||
| nonexistent_path: ( | |||
| r#"{ "before": {}, "experimentalSpaces": { "id": "one" }, "experimentalSpaces": { "id": "two" }, "after": {} }"#, | |||
There was a problem hiding this comment.
technically these tests have nothing to do with spaces, but I didn't want to confuse future contributors with an irrelevant key
7ebddeb to
e934c04
Compare
cdcd87b to
53cd9c3
Compare
53cd9c3 to
a837e7e
Compare
chris-olszewski
approved these changes
Feb 19, 2025
chris-olszewski
added a commit
that referenced
this pull request
Feb 27, 2025
### Description After #9961 this field is no longer used and produces a warning. ### Testing Instructions No warning on CI about the spaces id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deletes spaces code
Testing Instructions