ci: add check-types task to examples testing
#9824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
check-types task to examples testing
anthonyshew
commented
Jan 27, 2025
chris-olszewski
approved these changes
Jan 29, 2025
| # and it's reasonable to assume that they will continue to do so | ||
| turbo_command="turbo build lint --continue --output-logs=errors-only" | ||
| # with-svelte is flaky when building and check types at the same time, because the build process of Svelte involves type generation | ||
| # If the types are generating while the type checking happens, it can cause flakes. |
There was a problem hiding this comment.
Does this indicate that we should have "check-types": {"dependsOn": ["build"]} for the Svelte example to make sure that type generation completes before we try to check them?
This was referenced May 30, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the interest of keeping the examples robust, let's also run the newly added
check-typestask in CI to ensure those stay in the green when people try them out for the first time, too.Doing this uncovered some issues with existing examples, so glad to see that this will get us to a more stable place!
A notable exception, unfortunately, is going to be the
check-typesinwith-svelte. Svelte appears to be doing some type generation that can interrupt the type-checking process and make it flake out.Testing Instructions
CI