chore: suggest ways to break cyclic dependencies #9799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Aesthetic requests:
- If you can remove the curlies from
{@repo/eslint-config -> web}or put a space between them and the text, that'd be neat. - If you can put a new line before the
The cycle can be broken by removing any of these sets of dependencies:, that'd also be neat.
anthonyshew
approved these changes
Jan 28, 2025
8438985 to
a2da65a
Compare
This was referenced Jan 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #9270 by providing a suggestion on how to break a cycle found in the package graph.
This implementation will only show the smallest cuts that could be made to break a cycle. So if the cycle can be broken by cutting only 2 dependencies than no cuts requiring 3 dependencies will be displayed.
This also removes an error stutter we had when hitting cycles. Previously we would display two copies of the underlying error.
Before:
After:
Testing Instructions
Unit tests for the cut sets as well as a snapshot test that displays the additional suggestion now on the error message.