vercel · dimitropoulos · Jan 24, 2025 · Jan 24, 2025
@@ -248,6 +248,8 @@ impl AbsoluteSystemPath {
         )
     }
 
+    /// Note: This does not handle resolutions, so `../` in a path won't
+    /// resolve.
     pub fn anchor(&self, path: &AbsoluteSystemPath) -> Result<AnchoredSystemPathBuf, PathError> {
         AnchoredSystemPathBuf::new(self, path)
     }

@@ -73,6 +73,8 @@ impl<'a> From<&'a AnchoredSystemPathBuf> for wax::CandidatePath<'a> {
 }
 
 impl AnchoredSystemPathBuf {
+    /// Note: This does not handle resolutions, so `../` in a path won't
+    /// resolve.
     pub fn new(
         root: impl AsRef<AbsoluteSystemPath>,
         path: impl AsRef<AbsoluteSystemPath>,

@@ -122,6 +122,12 @@ impl<'a, PD: PackageChangeMapper> ChangeMapper<'a, PD> {
     pub fn changed_packages(
         &self,
         changed_files: HashSet<AnchoredSystemPathBuf>,
+        // None - we don't know if the lockfile changed
+        //
+        // Some(None) - we know the lockfile changed, but don't know exactly why (i.e. `git status`
+        // and the lockfile is there)
+        //
+        // Some(Some(content)) - we know the lockfile changed and have the contents
         lockfile_change: Option<Option<Vec<u8>>>,
     ) -> Result<PackageChanges, ChangeMapError> {
         if let Some(file) = Self::default_global_file_changed(&changed_files) {

@@ -11,6 +11,34 @@ for the JS API.
 
 This package contains scripts to build dev and release versions. `pnpm build && pnpm package` will build and package a dev version of the native library for `darwin-arm64`, or you can pass an additional argument for a specific target. `pnpm build:release` will build a release version of the library
 
-# Publishing
+## Setup
+
+Install JS dependencies:
+
+```sh
+pnpm install
+```
+
+## Build
+
+Build native library and TypeScript wrapper:
+
+```sh
+pnpm build
+cargo build
+```
+
+## Test
+
+```sh
+pnpm test
+```
+
+## Example Usage
+
+You can see examples in the `__tests__` directory, or see a simple script in `node scripts/test.mjs`.
+Note that this may fall out of date over time, but it's meant to be used during the early iterations.
+
+## Publishing
 
 There is now a version bump script in [bump-version.sh](./scripts/bump-version.sh). Passing it the new version will bump the meta package version, as well as the optional dependencies list and native packages.
@@ -6,9 +6,10 @@ import { Workspace, Package, PackageManager } from "../js/dist/index.js";
 type PackageReduced = Pick<Package, "name" | "relativePath">;
 
 interface AffectedPackagesTestParams {
+  description: string;
   files: string[];
+  changedLockfile?: string | undefined | null;
   expected: PackageReduced[];
-  description: string;
 }
 
 describe("affectedPackages", () => {
@@ -33,22 +34,48 @@ describe("affectedPackages", () => {
     },
     {
       description:
-        "global change should be irrelevant but still triggers all packages",
-      files: ["README.md"],
-      expected: [
-        { name: "app-a", relativePath: "apps/app" },
-        { name: "ui", relativePath: "packages/ui" },
-      ],
+        "a lockfile change will only affect packages impacted by the change",
+      files: [],
+      changedLockfile: `lockfileVersion: '6.0'
+
+settings:
+  autoInstallPeers: true
+  excludeLinksFromLockfile: false
+
+importers:
+
+  .: {}
+
+  apps/app:
+    dependencies:
+      microdiff:
+        specifier: ^1.4.0
+        version: 1.5.0
+      ui:
+        specifier: workspace:*
+        version: link:../../packages/ui
+
+  packages/blank: {}
+
+  packages/ui: {}
+
+packages:
+
+  /microdiff@1.5.0:
+    resolution: {integrity: sha512-Drq+/THMvDdzRYrK0oxJmOKiC24ayUV8ahrt8l3oRK51PWt6gdtrIGrlIH3pT/lFh1z93FbAcidtsHcWbnRz8Q==}
+    dev: false
+`,
+      expected: [{ name: "app-a", relativePath: "apps/app" }],
     },
   ];
 
-  for (const { description, files, expected } of tests) {
+  for (const { description, files, expected, changedLockfile } of tests) {
     it(description, async () => {
       const dir = path.resolve(__dirname, "./fixtures/monorepo");
       const workspace = await Workspace.find(dir);
 
       const reduced: PackageReduced[] = (
-        await workspace.affectedPackages(files)
+        await workspace.affectedPackages(files, changedLockfile)
       ).map((pkg) => {
         return {
           name: pkg.name,

@@ -1,6 +1,7 @@
 {
   "name": "app-a",
   "dependencies": {
-    "ui": "*"
+    "microdiff": "^1.4.0",
+    "ui": "workspace:*"
   }
 }
@@ -1,4 +1,4 @@
 {
   "name": "basic",
-  "packageManager": "pnpm@8.1.0"
+  "packageManager": "pnpm@8.14.0"
 }
@@ -55,5 +55,8 @@ export class Workspace {
    * of strings relative to the monorepo root and use the current system's
    * path separator.
    */
-  affectedPackages(files: Array<string>): Promise<Array<Package>>;
+  affectedPackages(
+    files: Array<string>,
+    changedLockfile?: string | undefined | null
+  ): Promise<Array<Package>>;
 }
@@ -18,5 +18,8 @@ tokio = { workspace = true }
 turbopath = { workspace = true }
 turborepo-repository = { workspace = true }
 
+[dev-dependencies]
+pretty_assertions = { workspace = true }
+
 [build-dependencies]
 napi-build = "2.0.1"
@@ -1,20 +1,5 @@
-## Setup:
+# `turbo-repository`
 
-Install JS dependencies:
+This sub-crate provides repository helpers which are written in Rust and translated to TypeScript with [NAPI-RS](https://napi.rs).
 
-```
-pnpm i
-```
-
-## Build:
-
-Build native library and js wrapper
-
-```sh
-pnpm build
-```
-
-## Example Usage
-
-You can see examples in the `__tests__` directory, or see a simple script in `node scripts/test.mjs`.
-Note that this may fall out of date over time, but it's meant to be used during the early iterations.
+See the [root `README.md` for instructions](../README.md).
@@ -7,14 +7,14 @@
 use napi_derive::napi;
 use turbopath::{AbsoluteSystemPath, AnchoredSystemPathBuf};
 use turborepo_repository::{
-    change_mapper::{ChangeMapper, DefaultPackageChangeMapper, PackageChanges},
+    change_mapper::{ChangeMapper, GlobalDepsPackageChangeMapper, PackageChanges},
     inference::RepoState as WorkspaceState,
     package_graph::{PackageGraph, PackageName, PackageNode, WorkspacePackage, ROOT_PKG_NAME},
 };
 mod internal;
 
 #[napi]
-#[derive(PartialEq, Eq, Hash, Clone)]
+#[derive(PartialEq, Eq, Hash, Clone, Debug)]
 pub struct Package {
     pub name: String,
     /// The absolute path to the package root.
@@ -27,7 +27,7 @@

 /// Wrapper for dependents and dependencies.
 /// Each are a list of package paths, relative to the workspace root.
 #[napi]
 #[derive(Debug)]
 pub struct PackageDetails {
    /// the package's dependencies
@@ -39,14 +39,14 @@
 }

 #[derive(Clone)]
 #[napi]
 pub struct PackageManager {
    /// The package manager name in lower case.
    #[napi(readonly)]
    pub name: String,
 }

 #[napi]
 pub struct Workspace {
    workspace_state: WorkspaceState,
    /// The absolute path to the workspace root.
@@ -62,7 +62,7 @@
    graph: PackageGraph,
 }

 #[napi]
 impl Package {
    fn new(
        name: String,
@@ -127,7 +127,7 @@
    }
 }

 #[napi]
 impl Workspace {
    /// Finds the workspace root from the given path, and returns a new
    /// Workspace.
@@ -187,12 +187,15 @@
     /// of strings relative to the monorepo root and use the current system's
     /// path separator.
     #[napi]
-    pub async fn affected_packages(&self, files: Vec<String>) -> Result<Vec<Package>, Error> {
+    pub async fn affected_packages(
+        &self,
+        files: Vec<String>,
+        changed_lockfile: Option<String>,
+    ) -> Result<Vec<Package>, Error> {
         let workspace_root = match AbsoluteSystemPath::new(&self.absolute_path) {
             Ok(path) => path,
             Err(e) => return Err(Error::from_reason(e.to_string())),
         };
-
         let hash_set_of_paths: HashSet<AnchoredSystemPathBuf> = files
             .into_iter()
             .filter_map(|path| {
@@ -203,9 +206,11 @@
             .collect();
 
         // Create a ChangeMapper with no ignore patterns
-        let default_package_detector = DefaultPackageChangeMapper::new(&self.graph);
-        let mapper = ChangeMapper::new(&self.graph, vec![], default_package_detector);
-        let package_changes = match mapper.changed_packages(hash_set_of_paths, None) {
+        let global_deps_package_detector =
+            GlobalDepsPackageChangeMapper::new(&self.graph, std::iter::empty::<&str>()).unwrap();
+        let mapper = ChangeMapper::new(&self.graph, vec![], global_deps_package_detector);
+        let lockfile_change = changed_lockfile.map(|s| Some(s.into_bytes()));
+        let package_changes = match mapper.changed_packages(hash_set_of_paths, lockfile_change) {
             Ok(changes) => changes,
             Err(e) => return Err(Error::from_reason(e.to_string())),
         };