这是indexloc提供的服务,不要输入任何密码
Skip to content

chore(turbo): include schema in turbo package #9714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Jan 16, 2025

Description

Add a new @turbo/types#copy-schema task which will copy the current schema into packages/turbo. We do this since we explicitly exclude the turbo package from our workspace so it's easier to have this hang off of @turbo/types.

We then add this task to the build target which is a dependency of the publish-turbo target which is what gets run on release: https://github.com/vercel/turborepo/actions/runs/12796720464/job/35678219119#step:11:2

Resolves #7466

Testing Instructions

Do a test run of the release and make sure we end up running the new copy-schema task. Started here, will take a sec to get to the point in the release where we hit this codepath.

You can see schema gets copied into the turbo package here

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:52pm

@chris-olszewski chris-olszewski marked this pull request as ready for review January 16, 2025 15:56
@chris-olszewski chris-olszewski requested a review from a team as a code owner January 16, 2025 15:56
@chris-olszewski chris-olszewski merged commit 09b62a5 into main Jan 17, 2025
51 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_include_schema_in_package branch January 17, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants