fix(watch): correctly derive opts from watch mode args #9761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds test for loading opts from various commands
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NicholasLYang
commented
Jan 22, 2025
| @@ -1,5 +0,0 @@ | |||
| {"run_id":"1737179308-428315000","line":309,"new":{"module_name":"turborepo_lib__task_graph__visitor__command__test","snapshot_name":"error_short_circuits_factory","metadata":{"source":"crates/turborepo-lib/src/task_graph/visitor/command.rs","assertion_line":309,"expression":"cmd.to_string()"},"snapshot":"Internal errors encountered: oops!"},"old":{"module_name":"turborepo_lib__task_graph__visitor__command__test","metadata":{},"snapshot":"internal errors encountered: oops!"}} | |||
There was a problem hiding this comment.
No clue what this was from. Probably not needed anymore?
anthonyshew
approved these changes
Jan 22, 2025
| "log_order": "Stream", | ||
| "summarize": false, | ||
| "experimental_space_id": null, | ||
| "is_github_actions": false, |
There was a problem hiding this comment.
I think you want to reduce the data caught in these snapshots. is_github_actions and log_order both get affected depending on where the tests will get run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I forgot to derive the
Optsstruct from the watch mode command. This PR does that and adds a test.Testing Instructions