fix: update oxc-resolver and fix windows bug #9754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
120bb13 to
a801035
Compare
a801035 to
bb7a179
Compare
bb7a179 to
8f1c30a
Compare
7dd427d to
985e707
Compare
chris-olszewski
approved these changes
Feb 25, 2025
| @@ -453,7 +453,19 @@ impl Tracer { | |||
| return (errors, None); | |||
| }; | |||
|
|
|||
| for import in imported_files { | |||
| for mut import in imported_files { | |||
| if cfg!(windows) { | |||
There was a problem hiding this comment.
Can you add a comment here explaining the bug this fixes?
|
Yeah the existing test suite caught the issue. It just blocked us from upgrading oxc-resolver. Although tbh I don't exactly know how to trigger windows path abbreviations, it just sort of happens |
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades oxc-resolver and fixes a bug that we found in Windows. We need to canonicalize paths manually since they may be the abbreviated version and that breaks our path equality logic.
Testing Instructions