这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: print detected package manager version in create-turbo options #9548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Dec 1, 2024

Description

Prints the package manager version that we're detecting on the user's machine.

CleanShot 2024-12-02 at 08 53 20

Goals here are:

  • More information for the user
  • Likely easier debugging for us. A report of something going wrong with create-turbo is likely to include more information. This helped me while trying to figure out what's up with fix: upgrade the turbo package in Yarn 4 #8076.

Hesitation

I could see the argument that our users didn't really request this information at this time, so it's just noise?

Testing Instructions

👀

@anthonyshew anthonyshew requested a review from a team as a code owner December 1, 2024 20:08
@turbo-orchestrator turbo-orchestrator bot added the pkg: create-turbo Issues related to npx create-turbo label Dec 1, 2024
Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 3:53pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:53pm

@anthonyshew anthonyshew changed the title feat: print detected package manager version in create-turbo options feat: print detected package manager version in create-turbo options Dec 1, 2024
@anthonyshew
Copy link
Contributor Author

anthonyshew commented Dec 2, 2024

Closing, we discussed and didn't like it because this info could be misunderstood in a couple different ways.

@anthonyshew anthonyshew closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-turbo Issues related to npx create-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant